Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: track web sockets like we track fetch #1613

Closed
wants to merge 1 commit into from
Closed

draft: track web sockets like we track fetch #1613

wants to merge 1 commit into from

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 17, 2024 •
edited
Loading

draft of websocket tracking to see where we're at

  • a second example would be good to avoid over-fitting to socket.io by accident
  • need to handle web sockets that are setup before posthog inits (or accept that coverage won't be great)
  • browsers don't support performance observer output for websockets, so i don't think we should try and get timing

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ❌ Failed (Inspect) Dec 17, 2024 10:32am

@github-actions GitHub Actions
Copy link

Size Change: +2.65 kB (+0.08%)

Total Size: 3.34 MB

Filename Size Change
dist/array.full.es5.js 262 kB +264 B (+0.1%)
dist/array.full.js 365 kB +266 B (+0.07%)
dist/array.full.no-external.js 364 kB +266 B (+0.07%)
dist/array.js 179 kB +264 B (+0.15%)
dist/array.no-external.js 178 kB +264 B (+0.15%)
dist/main.js 180 kB +264 B (+0.15%)
dist/module.full.js 365 kB +266 B (+0.07%)
dist/module.full.no-external.js 364 kB +266 B (+0.07%)
dist/module.js 179 kB +264 B (+0.15%)
dist/module.no-external.js 178 kB +264 B (+0.15%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-next.js 115 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra changed the title nope draft: track web sockets like we track fetch Dec 18, 2024
@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @posthog-bot